Deserialize auto populated columns on Active Record object creation #53436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #53435
This Pull Request has been created because values returned from the databases need to be deserialized as they may use a different format, such as PostgreSQL bytea "hex" format.
Detail
This Pull Request replaces
#write_from_user
with#write_from_database
when assigning the auto populated values returned by the database.Additional information
I don't like the fact that we access
@attributes
directly, but#reload
does it too and it's the simplest solution.Alternatives considered:
_write_attribute_from_database
method somewhere (ActiveRecord::AttributeMethods::Write
?).attributes_builder.types[column].deserialize(value)
.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]