No dump of the entire template when a syntax error is encountered: #54410
+71
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edouard-chin
force-pushed
the
ec-syntax-error
branch
from
73d17fa to
908f2c0
Compare
|
This looks so much better! |
- When rendering a erb template with a syntax error, we were previously dumping the entire content of the template file into the debug view, un-itended, un-highlighted and all in red. It really doesn't help and distract a user from seeing the actually useful stack trace. The only time where this could be useful is when we render a inline template (that could be dynamicallt generated), and therefore it kinda make sense to dump it's content. This commit prevents dumping the content of the template if rendered from a file, and will keep dumping inline content.
Edouard-chin
force-pushed
the
ec-syntax-error
branch
from
908f2c0 to
87296b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
No dump of the entire template when a syntax error is encountered:
When rendering a erb template with a syntax error, we were previously dumping the entire content of the template file into the debug view, un-itended, un-highlighted and all in red. It really doesn't help and distract a user from seeing the actually useful stack trace.
The only time where this could be useful is when we render a inline template (that could be dynamicallt generated), and therefore it kinda make sense to dump it's content.
This commit prevents dumping the content of the template if rendered from a file, and will keep dumping inline content.
Before
After
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]