Fix 55215 test failure

[fabricerenard12]

Motivation / Background

Fixes #55215

Detail

This Pull Request adds require "action_controller" to railties/lib/rails/health_controller.rb, guaranteeing ActionController::Base is loaded before Rails::HealthController is defined and eliminating the NameError seen in #55215.

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
• Tests are added or updated if you fix a bug or add a feature.
• CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

[skipkayhil]

👋 hey @fabricerenard12, thanks for taking a stab at this! It looks like there's a real failure in CI, could you take a look?

[Edouard-chin]

I think the right fix is to require "action_controller` only so that all autoloads' are setup.
Requiring the railtie should be opt-in. In a normal Rails application this would not matter much, but in standalone scripts like Rails bug report templates (e.g. https://github.com/rails/rails/blob/05f0b1614d82424a7507caaec5cf701d3a8c2b21/guides/bug_report_templates/active_job.rb) we want to be able to choose which railtie to load.

[Edouard-chin]

We we'll also need to modify the Rails::ApplicationController with the same fix https://github.com/rails/rails/blob/05f0b1614d82424a7507caaec5cf701d3a8c2b21/railties/lib/rails/application_controller.rb

It's the parent class of the PwaController which gets also eagerloaded. (it works right now without issue but if we end up swapping these two lines in the future it would fail the same way)

rails/railties/lib/rails.rb

Lines 34 to 37 in 05f0b16

	eager_autoload do
	autoload :HealthController
	autoload :PwaController
	end

)

Thanks !

[Edouard-chin]

👍 ! Someone from the team with commit privilege will review and merge when they get the chance.

Thanks for your contribution !