[RF-DOCS] Wishlists guide #55428
[RF-DOCS] Wishlists guide #55428
Conversation
| This guide covers adding Wishlists to the store e-commerce application in the | ||
| [Getting Started Guide](getting_started.html)). We will use the code from the | ||
| [Sign up and Settings Guide](sign_up_and_settings.html) as a starting place. |
There was a problem hiding this comment.
Wishlist: have all the code from the previous guides ready so I don't have to follow them all before starting this one haha.
There was a problem hiding this comment.
That isn't a bad idea. Maybe we should put the getting started code in a repository that people can clone?
There was a problem hiding this comment.
A problem is that the repo would get out of sync as we update the tutorials.
There was a problem hiding this comment.
This came up in conversation with @excid3 when we were updating the Getting Started Guide, but the longterm maintenance as @MatheusRich says would be an issue.
@rafaelfranca Could this be in the Rails GitHub or would do you think an external repo is better?
There was a problem hiding this comment.
I think an external repo. There are ways to make maintenance easier. We could write a script that generate the repo and keep it inside the repo and make sure its content is the same as the guide.
| This guide covers adding Wishlists to the store e-commerce application in the | ||
| [Getting Started Guide](getting_started.html)). We will use the code from the | ||
| [Sign up and Settings Guide](sign_up_and_settings.html) as a starting place. |
There was a problem hiding this comment.
That isn't a bad idea. Maybe we should put the getting started code in a repository that people can clone?
| ```ruby | ||
| class Wishlist < ApplicationRecord | ||
| belongs_to :user | ||
| has_many :wishlist_products, dependent: :destroy |
There was a problem hiding this comment.
I think the proper name for this association and the model would be wishlisted_products, no?
There was a problem hiding this comment.
Could be, if you think of this as an adjective ("products that were wishlisted"), but wishlist_products also work as "products that are on a wishlist".
guides/source/wishlists.md
Outdated
| require "test_helper" | ||
|
|
||
| class WishlistTest < ActiveSupport::TestCase | ||
| test "has friendly urls" do |
There was a problem hiding this comment.
IDK how I feel about this test. This seems mostly to be testing Rails code (which we should assume is tested). Maybe we could test that we can find it? Or maybe no test for this at all, since the integration specs will catch it.
There was a problem hiding this comment.
Agreed, I'll swap this with a test for filter_by since that is something actually worth unit testing.
There was a problem hiding this comment.
Thank you @excid3! Great tutorial, as always. I learned something new today!
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Matheus Richard <matheusrichardt@gmail.com>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Matheus Richard <matheusrichardt@gmail.com>
Co-authored-by: Matheus Richard <matheusrichardt@gmail.com>
Co-authored-by: Matheus Richard <matheusrichardt@gmail.com>
Co-authored-by: Matheus Richard <matheusrichardt@gmail.com>
Co-authored-by: Matheus Richard <matheusrichardt@gmail.com>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Co-authored-by: Rafael Mendonça França <rafael@franca.dev>
Motivation / Background
This adds a new tutorial adding Wishlists to the e-commerce store as a follow-up to the Sign Up & Settings Guide. It builds upon the Rails knowledge learned so far and helps reinforce the concepts learned so far.
cc @AmandaPerino
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]