Add missing test when an array is passed to ActionMailer.deliver_all_later
#55660
Conversation
|
Thanks, but I I think it is not currently needed. |
|
@fatkodima I'm sorry but I have to insist. if you remove this line: deliveries = deliveries.first if deliveries.first.is_a?(Array)All tests still pass. which means my line as it stand does not hold any value theoretically. However when I add these tests: 
Could you please reconsider re-opening and merging please |
| mail1 = DelayedMailer.test_message(1) | ||
| mail2 = DelayedMailer.test_message(2) | ||
|
|
||
| ActionMailer.deliver_all_later([mail1, mail2]) |
There was a problem hiding this comment.
@fatkodima could you please tell me why this is not needed? I'm passing an array, and the splat operator transforms it into : [[ mail1, mail2 ]] so I still need to test this case to check it does not break
maybe it should be extracted into another, more generic test, test "deliver_all_later accepts an array of mailers"
because this is something that was not tested before with flatten! ( if you remove flatten! tests were still passing because you didn not add any test with an array of mailers ActionMailer.deliver_all_later([mail1, mail2])
In fact if you remove deliveries.flatten! and run the tests they still pass, which is an issue for me
2 participants
related to #55659
cc @fatkodima
Add test for the
if deliveries.first.is_a?(Array)case