Don't output deprecated message in newly generated applications #55793
+22
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rails#55496, the depreciation message about `raise_on_open _redirects` is shown in newly generated applications. This is because the deprecations is shown when `raise_on_open_redirects` is not null, but the default value of it is `false`. https://github.com/rails/rails/blob/ec4337aae7d358e9d8ae3fc539347a2618b8fbe0/actionpack/lib/action_controller/railtie.rb#L110 https://github.com/rails/rails/blob/ec4337aae7d358e9d8ae3fc539347a2618b8fbe0/actionpack/lib/action_controller/railtie.rb#L15 In addition that, we set the value in `load_defaults`. https://github.com/rails/rails/blob/ec4337aae7d358e9d8ae3fc539347a2618b8fbe0/railties/lib/rails/application/configuration.rb#L270 This PR removed config key and checked the key existence for the condition of deprecation message. Fixes rails#55772.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because since #55496, the depreciation message about
raise_on_open _redirectsis shown in newly generated applications.This is because the deprecations is shown when
raise_on_open_redirectsis not null, but the default value of it isfalse.rails/actionpack/lib/action_controller/railtie.rb
Line 110 in ec4337a
rails/actionpack/lib/action_controller/railtie.rb
Line 15 in ec4337a
In addition that, we set the value in
load_defaults.rails/railties/lib/rails/application/configuration.rb
Line 270 in ec4337a
Detail
This Pull Request removed config key and checked the key existence for the condition of deprecation message to avoid the deprecation message in newly generated applications.
Fixes #55772.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]