Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken test "test_compilation_error" #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wwood
Copy link

@wwood wwood commented Dec 27, 2015

Hi there,

I'm in the process of packaging ruby-coffee-script for GNU Guix, and I came across this failing test. Seemed easy enough to fix, so here it is.

Beforehand:

Run options: --seed 49250

# Running:

..F....

Finished in 0.107786s, 64.9436 runs/s, 102.0542 assertions/s.

  1) Failure:
TestCoffeeScript#test_compilation_error [/tmp/nix-build-ruby-coffee-script-2.4.1.drv-0/ruby-coffee-script-2.4.1/test/test_coffee_script.rb:70]:
message was "[stdin]:3:11: unexpected unless"

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@wwood
Copy link
Author

wwood commented Dec 27, 2015

So, upon further reflection, it isn't immediately obvious to me why it was failing in the first place. Here's the gems I have loaded. Perhaps because I am using duktape and not rubyracer? I am not sure, perhaps you know better.

bigdecimal (1.2.6)
coffee-script-source (1.10.0)
duktape (1.3.0.4)
execjs (2.6.0)
io-console (0.4.3)
json (1.8.1)
minitest (5.4.3)
power_assert (0.2.2)
psych (2.0.8)
rake (10.4.2)
rdoc (4.2.0)
test-unit (3.0.8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants