Use Gem.use_paths method for setting paths #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fixes case for JRuby which returns a regexp from Gem.path_separator, but also improves code by using built in method instead of passing string that later is changed to array again.
|
r? @grosser (@rails-bot has picked a reviewer for you, use r? to override) |
|
👍 @jeremy double check plz |
|
lgtm /cc @tenderlove |
|
@tenderlove Do you think this solution is good to go? |
|
This happened to me after I upgraded to rubygem 2.6.6. Before I always at 2.4.5.1 and everything was fine. |
| @@ -38,7 +38,7 @@ class Binstub < Command | |||
| require 'bundler' | |||
|
|
|||
| if (match = Bundler.default_lockfile.read.match(/^GEM$.*?^ (?: )*spring \((.*?)\)$.*?^$/m)) | |||
| Gem.paths = { 'GEM_PATH' => [Bundler.bundle_path.to_s, *Gem.path].uniq.join(Gem.path_separator) } | |||
| Gem.use_paths Gem.dir, Bundler.bundle_path.to_s, *Gem.path | |||
There was a problem hiding this comment.
I this going to work on old versions of rubygems?
There was a problem hiding this comment.
I see the method is there for a while indeed.
|
double checked and it works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes case for JRuby which returns a regexp from Gem.path_separator,
but also improves code by using built in method instead of passing string that later is changed to array again.
It follows discussion from https://github.com/rails/spring/pull/472/files#r54284442