Add testing curriculum #613
Conversation
Set up branch
add types of tests section
add additional concepts section
Testing curriculum
|
Heya @akanshmurthy and @schaui6, @tjgrathwell is out for a bit, possibly longer so I will review it. I should be able to to that in the next couple of days and then we will get it folded into the curricula. And of course anyone else watching this your comments and feedback are appreciated as well. Congrats on the successful class and thanks again for all of your hard work making this happen. :) |
|
Oh hey! Could you include a live link to this as well? I might have another couple people look at it quickly and that is easier to do from a live heroku app. |
|
Also @tjgrathwell might still be around so if you are please go ahead yourself with comments and such! |
|
Hi @akanshmurthy and @schaui6! I'm testing out this curriculum and I found some errors on "Types Of Tests". In Steps 2 and 4, the tests don't pass without adding stuff (associations, resources, actions, etc). This is a great chance to do some error-driven teaching, so I'm working on fleshing out Steps 2 and 4. Just wanted to give you a heads-up, I'm working on a PR for ya! |
|
@camillevilla : awesome, thanks! I do notice that the class Orange at the top only displays class Orange. It's supposed to display a whole class file with the associations. That might be an easy fix (I think the indentation in the step file might be a culprit). And, for the resources/actions, we could just state that along with "Copy the below test, paste it into the oranges controller spec file, create the relevant view files..."? Thoughts? |
|
Bump. |
|
hi @akanshmurthy! Here's what I've added:
I did some work in my own fork, but I'm not able to open a PR for your fork. Not sure if this is a GitHub permissions thing or just confusion on my part. Could you give me contributor permissions for |
|
@camillevilla : I've added you as a collaborator. Try now? @careful-with-that-axe or @tjgrathwell : can we please get a review of this PR? It's been 4 weeks... |
|
Great, thanks @akanshmurthy! PR is hanging out for your review. |
|
@Akansh: Sorry! I am just wrapping up a vacation but will be able to review
tomorrow afternoon.
Thanks for patience and also the ping so I do the right thing despite
getting distracted!
…On Mon, May 29, 2017 at 12:30 PM, Camille Villa ***@***.***> wrote:
Great, thanks @akanshmurthy <https://github.com/akanshmurthy>! PR is
hanging out for your review.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#613 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADV4z4_tr6TeLglawQ-4sjhbQa0r5eUyks5r-xzLgaJpZM4NM2dB>
.
|
|
Hi @akanshmurthy I have been busier than I expected so I had no time last night. I am going to try to swing around to it today during lunch. Thanks again for patience. |
…tests Edit association controller tests
|
@careful-with-that-axe : ok, thanks. I think Camille's updates have been merged in too. |
| @@ -24,6 +24,10 @@ site_desc 'message-board', <<-MARKDOWN | |||
| Build a message board! This curriculum is for students who have completed the Suggestotron and the Job Board curricula. This curriculum is a challenge because it won't tell you what to type in! | |||
| MARKDOWN | |||
|
|
|||
| site_desc 'testing', <<-MARKDOWN | |||
| Increase the stability of your Rails app by learning about tests: what they are, why they're used, and how to use them! This curriculum is for students who have completed the Suggestotron, the Job Board, and the Message Board curricula. There will be challenges! | |||
There was a problem hiding this comment.
It would better for this to have a longer name that is self describing at first glance. Even if a bit redundantly mentioning Rails is still good. Something like "Testing Rails Applications using RSpec etc..." Then someone can know at a glance what this is about. I am just starting the review process, I am swamped right now, but I will either complete a review tonight or just approve the branch tonight at the latest. This is the one thing I know needs to change now though and it might be the only thing.
|
working on merging this in soon with some updates |
|
Okay, merged and deployed 🚀 - http://docs.railsbridge.org/testing-rails-applications I named the curriculum "Testing Rails Applications" for now, we can change it again later if that seems badly scoped or worded. But usually names that are a little longer and unique are good because in the future it's easier to search the code for references to Made some amendments in 492d7f2 I also rebased all the commits, so anyone who was working on this should hard-reset to the current master if you want to continue development |
|
Awesome, thanks!! |
CC: @careful-with-that-axe @schaui6 @lilliealbert @aneyzberg
This contains the addition of a new curricula related to testing software. The reason for the addition is that testing plays a hugely important rule in the real world for software quality control and is a supplement to the current curricula, which focus mainly on building software.
This was originally tested as part of https://www.bridgetroll.org/events/324. Then, after creating a more structured curriculum, the content was tested in a real RailsBridge event: https://www.bridgetroll.org/events/347. This PR is the culmination of the feedback from that event.