Fixed a few memory leaks #1095
Closed
Fixed a few memory leaks #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
This PR (used with rakshasa/libtorrent#223) seems to be causing issues when SCGI is using a socket (network.scgi.open_local) instead of a port (network.scgi.open_port). rTorrent crashes with, |
TrimmingFool
reviewed
Apr 7, 2023
|
|
||
| std::wstring result(buf); | ||
|
|
||
| free(buf); |
There was a problem hiding this comment.
@stickz On a cursory view, this makes no sense to me. Where do you see a memory leak? Moreover, buf is allocated on the stack, freeing it is an error.
|
I'm going to cherry pick these commits and create separate pull requests. This will allow @rakshasa to choose which ones to merge. Not all of these fixes are stable apparently. But they have a significant impact reducing software memory leaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports a few memory leak fixes from jesec/rtorrent .
Requires the following rakshasa/libtorrent pull request to be merged first. rakshasa/libtorrent#223