Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in users.ipynb #726

Merged

Conversation

thomcom
Copy link
Contributor

@thomcom thomcom commented Oct 4, 2022

Description

After @isVoid fixed the bug that produced an error cell in users.ipynb it doesn't seem to be updating automatically - it is probably rendering the notebook, not executing it.

This PR updates the notebook with the removed bug.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Closes #725

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@thomcom thomcom self-assigned this Oct 4, 2022
@thomcom thomcom added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 4, 2022
@thomcom thomcom marked this pull request as ready for review October 4, 2022 18:57
@thomcom thomcom added this to the Developer Documentation milestone Oct 4, 2022
@harrism
Copy link
Member

harrism commented Oct 4, 2022

So that means it was pushed with an error previously. We'll have to be careful to check it over any time it is pushed.

@harrism harrism changed the title Push a users.ipynb that doesn't have the error cell. Fix error in users.ipynb Oct 4, 2022
@harrism
Copy link
Member

harrism commented Oct 4, 2022

(Renamed PR to be more release-notes-friendly).

@thomcom
Copy link
Contributor Author

thomcom commented Oct 4, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 22f4c43 into rapidsai:branch-22.10 Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] users.ipynb has an error cell.
2 participants