arena_memory_resource optimization: disable tracking allocated blocks by default #732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done similarly to #702.
Previously
arena_memory_resource
maintained a set of allocated blocks, but this was only used for reporting/debugging purposes. Maintaining this set requires aset::find
at every deallocation, which can get expensive when there are many allocated blocks. This PR moves the tracking behind a default-undefined preprocessor flag. This results in some speedup in the random allocations benchmark forarena_memory_resource
. Tracking can be enabled by definingRMM_POOL_TRACK_ALLOCATIONS
.This should also fix the Spark small shuffle buffer issue: NVIDIA/spark-rapids#1711
Before:
After:
@abellina