Simplify CMake linting with cmake-format #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please target 22.02 @vyasr . |
harrism
approved these changes
Nov 10, 2021
harrism
added
CMake
gpuCI
improvement
robertmaynard
requested changes
Nov 10, 2021
vyasr
force-pushed
the
linting/cmake-format
branch
from
e33a71f
to
8fc9142
Compare
|
I retargeted 22.02 before I force pushed the rebase, so a bunch of extra reviewer groups were requested that shouldn't be necessary. |
rongou
reviewed
Nov 11, 2021
robertmaynard
approved these changes
Nov 11, 2021
rongou
approved these changes
Nov 12, 2021
|
rerun tests |
|
Removing |
|
@vyasr if this is ready, go ahead and merge. |
|
@gpucibot merge |
1 similar comment
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Nov 20, 2021
This PR ports some improvements from rapidsai/rmm#913. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) - Robert Maynard (https://github.com/robertmaynard) URL: #9723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to find the cmake-format-rapids-cmake.json file in a standard location and run the cmake-format or cmake-lint programs with that config file. The script fails gracefully when the file cannot be found and is therefore suitable for use as a pre-commit hook in scenarios where no build directory (containing the config file) exists yet. A corresponding pre-commit configuration is added here as well, replacing the old cmake-format hook which did not use the rapids-cmake config file.
Resolves #903.