Skip to content

Small file fixes #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2025
Merged

Small file fixes #254

merged 2 commits into from
Jul 17, 2025

Conversation

will-v-pi
Copy link
Contributor

There are currently a couple of bugs when loading/saving/verifying small BIN files

  • <100 byte files cause an infinite loop - fix is to round up size/100
  • <256 byte files cause an unmapped exception when no family ID is specified - fix is to allow zero fill in RP2040 checksum

will-v-pi added 2 commits July 17, 2025 11:55
@will-v-pi
Fix rounding bug for load/save/verify small files
a4b761b 
Want to round up size/100, as a non-zero size should always give a non-zero chunk size
@will-v-pi
Allow zero fill when checking checksum
e3288dd 
Otherwise fails as unmapped for small files
@will-v-pi will-v-pi added this to the 2.1.2 milestone Jul 17, 2025
@will-v-pi will-v-pi requested a review from kilograham July 17, 2025 11:17
lurch
lurch reviewed Jul 17, 2025
View reviewed changes
@will-v-pi will-v-pi merged commit d5ee24b into develop Jul 17, 2025
41 checks passed
@will-v-pi will-v-pi deleted the small-file-fixes branch July 17, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch left review comments

@kilograham kilograham kilograham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@will-v-pi @lurch @kilograham