Feat: support disable doctype #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
可以不需要单独出 web，文档注释上说明即可 |
yuanyan
reviewed
Feb 18, 2020
| this.command = options.command; | ||
|
|
||
| // Disable doctype in `build.json` | ||
| this.doctype = options.doctype === 'none' ? '' : '<!DOCTYPE html>'; |
Contributor
There was a problem hiding this comment.
考虑这样
if (options.doctype == null) {
this.doctype = '';
} else {
this.doctype = options.doctype;
}
options.doctype 的默认值为 ''
Contributor
Author
There was a problem hiding this comment.
默认值不能设为 '', 是 breakchange 且用户无感知的
yuanyan
reviewed
Feb 18, 2020
| this.command = options.command; | ||
|
|
||
| // Disable doctype in `build.json` | ||
| this.doctype = options.doctype === null ? '' : `<!DOCTYPE ${options.doctype || 'html'}>`; |
Contributor
There was a problem hiding this comment.
如果有值，全部由用户来定制即可，这样逻辑上甚至可以支持 xml， <?xml version="1.0" encoding="UTF-8"?>
yuanyan
approved these changes
Feb 20, 2020
wssgcg1213
approved these changes
Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#185
Usage
disable doctype
{ "plugins": [ [ "build-plugin-rax-app", { "targets": ["web"], "doctype": null } ] ] }custom doctype