-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rubinius gems binstubs location #461
Conversation
Rubinius 2.0 configures RubyGems to install gem binstubs in `PREFIX/gems/bin` instead of just `PREFIX/bin`. The reason given by evanphx is that Rubinius wants to avoid RubyGems' binstubs conflating with those from other Rubies. http://git.io/XBWGew Fixes #178
This doesn't seem to work for me. This is rbenv installed via homebrew with this patch applied.
I'm not super familiar with rbenv internals or how to debug this. Am I missing something? |
@dstrelau Thanks for checking this out. It turns out my brain is broken, as I just solved the Rubinius issue half way and never actually made a change that actually makes the shims work for Rubinius. I've just pushed an additional commit that should take care of that. Running |
Awesome. This is working for me now. Thanks! |
When are you going to make release? Or how can I update rbenv through brew now to get this change? |
@ka8725 I'm using this formula with |
It's not suitable to install all ruby versions and their gems after upgrading... If I understand correctly after upgrading rbenv I can just move old rubies to new rbenv version's folder and it should work. Right? Also I applied this patch locally and I can approve that it works. 👍 for merge |
@ka8725 If you have Ruby versions installed in different locations on your system and want to make them available in rbenv without re-installing, you can symlink them into rbenv's version directory:
Don't move them with |
@sstephenson Any thoughts on this? |
Note that this PR is incomplete: I haven't patched I'd rather patch ruby-build instead to symlink |
+1 to fixing this in ruby-build instead. |
Nuking this with 🔥 |
Rubinius 2 insists that it installs RubyGems binstubs into `PREFIX/gems/bin` instead of `PREFIX/bin`. This creates complexity for rbenv rehash and exec processes, so we symlink `gems/bin` into `bin` and have RubyGems create binstubs at a location that is consistent with other Ruby implementations. See rbenv/rbenv#178, rbenv/rbenv#461
Rubinius 2.0 configures RubyGems to install gem binstubs in
PREFIX/gems/bin
instead of justPREFIX/bin
.The reason given by evanphx is that Rubinius wants to avoid RubyGems' binstubs conflating with those from other Rubies. http://git.io/XBWGew
Fixes #178
/cc @sstephenson