Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten dep version bounds #138

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Tighten dep version bounds #138

merged 1 commit into from
Dec 31, 2019

Conversation

tkoolen
Copy link
Collaborator

@tkoolen tkoolen commented Dec 28, 2019

To appease General registry auto-merge bot.

Fixes #137.

I skimmed the release pages for each of these dependencies and came up with what I thought would be reasonable bounds. I omitted versions that came before Julia 1.0 support was added and for Rotations I skipped a release I botched.

To appease General registry auto-merge bot.

Fixes #137.

I skimmed the release pages for each of these dependencies and came up
with what I thought would be reasonable bounds. I omitted versions that
came before Julia 1.0 support was added and for Rotations I skipped a
release I botched.
@tkoolen tkoolen requested a review from rdeits December 29, 2019 14:56
@rdeits
Copy link
Owner

rdeits commented Dec 30, 2019

Thanks! I'll try to figure out why the appveyor build is broken.

@tkoolen tkoolen closed this Dec 31, 2019
@tkoolen tkoolen reopened this Dec 31, 2019
@codecov-io
Copy link

codecov-io commented Dec 31, 2019

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   76.41%   76.41%           
=======================================
  Files          15       15           
  Lines         458      458           
=======================================
  Hits          350      350           
  Misses        108      108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ecad2...6a0c642. Read the comment docs.

@tkoolen
Copy link
Collaborator Author

tkoolen commented Dec 31, 2019

So to be fully clear: on Travis Julia version 1 means latest Julia version 1.0.x. On Appveyor, it means latest Julia version 1.x.y. Tests should pass on all platforms now (new version of Blink was released).

@tkoolen tkoolen merged commit 5d2c26f into master Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need tighter dependency version bounds for auto-merging of version tags
3 participants