Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setprop! calls now persist across new connections #142

Merged
merged 7 commits into from
Feb 12, 2020
Merged

Conversation

rdeits
Copy link
Owner

@rdeits rdeits commented Feb 11, 2020

On top of #141

Fixes #35

@codecov-io
Copy link

Codecov Report

Merging #142 into master will increase coverage by 2.2%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #142     +/-   ##
=========================================
+ Coverage   79.27%   81.47%   +2.2%     
=========================================
  Files          15       18      +3     
  Lines         468      475      +7     
=========================================
+ Hits          371      387     +16     
+ Misses         97       88      -9
Impacted Files Coverage Δ
src/lowering.jl 98.48% <ø> (+8.2%) ⬆️
src/commands.jl 83.33% <ø> (+11.9%) ⬆️
src/assets.jl 0% <0%> (ø)
src/servers.jl 4% <0%> (-0.55%) ⬇️
src/integrations.jl 100% <100%> (ø)
src/trees.jl 92.59% <100%> (ø) ⬆️
src/MeshCat.jl 80% <100%> (+46.66%) ⬆️
src/ijulia.jl 33.33% <33.33%> (ø)
src/visualizer.jl 91.66% <91.3%> (+15.61%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d0be1...f2e5d41. Read the comment docs.

@rdeits rdeits merged commit 0629bd9 into master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SetProperty commands don't update the internal tree
3 participants