Skip to content

feat: Remove viewing restrictions spec #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 26, 2025
Merged

feat: Remove viewing restrictions spec #406

merged 5 commits into from
Aug 26, 2025

Conversation

@alkalinecoffee
Copy link
Contributor

@alkalinecoffee alkalinecoffee commented Aug 1, 2025 •
edited
Loading

This feature is unreleased, but we've decided to move it to a private repo for now.

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

Failed to create a report:
Job logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/16676512323

@github-actions
Copy link

github-actions bot commented Aug 1, 2025 •
edited
Loading

Code Coverage

Package Line Rate Branch Rate Health
src 0% 0% ❌
src.Accessor 0% 0% ❌
src.Async 0% 0% ❌
src.Event 0% 0% ❌
src.Logger 0% 0% ❌
src.Transport 0% 0% ❌
Summary 0% (0 / 1195) 0% (0 / 1917) ❌

Code Coverage

Package Line Rate Branch Rate Health
src 0% 0% ❌
src.Accessor 0% 0% ❌
src.Async 0% 0% ❌
src.Event 0% 0% ❌
src.Logger 0% 0% ❌
src.Transport 0% 0% ❌
Summary 0% (0 / 1195) 0% (0 / 1917) ❌

Code Coverage

Package Line Rate Branch Rate Health
src 45% 19% ❌
src.Accessor 51% 25% ➖
src.Async 56% 21% ➖
src.Event 47% 17% ❌
src.Logger 96% 36% ✔
src.Properties 89% 25% ✔
src.Transport 46% 19% ❌
Summary 46% (2875 / 6286) 19% (2264 / 11885) ❌

Code Coverage

Package Line Rate Branch Rate Health
src 1% 0% ❌
src.Accessor 52% 24% ➖
src.Async 37% 9% ❌
src.Event 45% 17% ❌
src.Logger 96% 36% ✔
src.Properties 0% 0% ❌
src.Transport 33% 15% ❌
Summary 8% (348 / 4396) 3% (193 / 6315) ❌

Code Coverage

Package Line Rate Branch Rate Health
src 45% 19% ❌
src.Accessor 51% 25% ➖
src.Async 56% 21% ➖
src.Event 47% 17% ❌
src.Logger 96% 36% ✔
src.Properties 89% 25% ✔
src.Transport 46% 19% ❌
Summary 46% (2875 / 6286) 19% (2264 / 11885) ❌

Code Coverage

Package Line Rate Branch Rate Health
src 1% 0% ❌
src.Accessor 52% 24% ➖
src.Async 37% 9% ❌
src.Event 45% 17% ❌
src.Logger 96% 36% ✔
src.Properties 0% 0% ❌
src.Transport 33% 15% ❌
Summary 8% (348 / 4396) 3% (193 / 6315) ❌

Code Coverage

Package Line Rate Branch Rate Health
src 0% 0% ❌
src.Accessor 0% 0% ❌
src.Async 0% 0% ❌
src.Event 0% 0% ❌
src.Logger 0% 0% ❌
src.Transport 0% 0% ❌
Summary 0% (0 / 1195) 0% (0 / 1917) ❌

Code Coverage

Package Line Rate Branch Rate Health
src 0% 0% ❌
src.Accessor 0% 0% ❌
src.Async 0% 0% ❌
src.Event 0% 0% ❌
src.Logger 0% 0% ❌
src.Transport 0% 0% ❌
Summary 0% (0 / 1195) 0% (0 / 1917) ❌

Code Coverage

Package Line Rate Branch Rate Health
src 0% 0% ❌
src.Accessor 0% 0% ❌
src.Async 0% 0% ❌
src.Event 0% 0% ❌
src.Logger 0% 0% ❌
src.Transport 0% 0% ❌
Summary 0% (0 / 1195) 0% (0 / 1917) ❌

@github-actions
Copy link

github-actions bot commented Aug 1, 2025

Failed to create a report:
Job logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/16676599413

tomasz-blasz
tomasz-blasz requested changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@tomasz-blasz tomasz-blasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changelog modification. The ViewingRestrictions feature was merged into 1.5.0-next.19 via PR #363, and that information should remain unchanged. Without it, the new entry that semantic-release will generate ("Remove viewing restrictions spec") upon merging this PR will appear awkward and illogical, because, based on the changelog, it would seem that such functionality was never added. Added functionality always will be accessible in the history of the repository.

@alkalinecoffee
Copy link
Contributor Author

Done @tomasz-blasz

@github-actions
Copy link

Failed to create a report:
Job logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/17163369839

@github-actions
Copy link

Failed to create a report:
Job logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/17211190320

@github-actions
Copy link

Failed to create a report:
Job logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/17232586073

@tomasz-blasz tomasz-blasz merged commit 077d427 into next Aug 26, 2025
11 of 14 checks passed
@tomasz-blasz tomasz-blasz deleted the remove-viewing-restrictions branch August 26, 2025 09:23
aczs pushed a commit that referenced this pull request Aug 26, 2025
@semantic-release-bot
chore(release): 1.7.0-next.1 [skip ci]
68817fa 
# [1.7.0-next.1](v1.6.0...v1.7.0-next.1) (2025-08-26)

### Features

* Remove viewing restrictions spec ([#406](#406)) ([077d427](077d427))
@aczs
Copy link
Collaborator

aczs commented Aug 26, 2025

🎉 This PR is included in version 1.7.0-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

aczs pushed a commit that referenced this pull request Sep 4, 2025
@semantic-release-bot
chore(release): 1.7.0 [skip ci]
86c3fe2 
# [1.7.0](v1.6.0...v1.7.0) (2025-09-04)

### Features

* Remove viewing restrictions spec ([#406](#406)) ([077d427](077d427))
@aczs
Copy link
Collaborator

aczs commented Sep 4, 2025

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aczs aczs added the released label Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasz-blasz tomasz-blasz tomasz-blasz approved these changes

Assignees

No one assigned

Labels

released on @next released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alkalinecoffee @aczs @tomasz-blasz