-
Notifications
You must be signed in to change notification settings - Fork 431
customized classes and id on BootstrapTable (#235) #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
customized classes and id on BootstrapTable (#235) #247
Conversation
Hi @AllenFang, For previous customized classes, take rowClasses or example, it accepted |
Besides, should I update the docs as well? |
Document should be patched only for |
return ( | ||
<div className="react-bootstrap-table"> | ||
<table className={ tableClass }> | ||
<table id={ id } className={ tableClass }> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About #235, I think we need to clarify the class/id is on outter div or table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Let's discuss further. What I think is that the benefit of customizing className
or id
on the table directly is that it not only allows users to pick up whatever they want but also supports classNames
from boostrap
.
For example: bootstrap4#tables
You can also invert the colors—with light text on dark backgrounds—with .table-dark.
<table class="table table-dark">
{ ... }
</table>
Thanks @Chun-MingChen |
Patch docs c11539b |
@AllenFang |
fix #235
This PR aims to support customized
className
andid
on BootstrapTable.