Skip to content

Conversation

chunming-c
Copy link
Member

Enhancement

lerna bootstrap with default npm instead of yarn to prevent from issue that caused by older version of yarn

  • lerna bootstrap after module install
  • remove all the yarn.lock in folder packages

* set npmClient to default instead of yarn to prevent from causing error with older yarn version
* ref: lerna/lerna#897
@AllenFang
Copy link
Member

Seems like some people do have commit package-lock.json to repo but some people is not...

https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

so any concern that why we avoid to commit package-lock.json to repo?

@AllenFang AllenFang added this to the 0.1.0 milestone Sep 8, 2017
@chunming-c
Copy link
Member Author

The reason why I skip package-lock.json is that I want to keep our repo maintained by one package manager, that is yarn. Therefore, that's the reason why I omit this.

ref: https://github.com/babel/babel/blob/master/.gitignore#L13

@chunming-c
Copy link
Member Author

chunming-c commented Sep 8, 2017

However, you may be curious about why I remove all the yarn.lock in folder packages.lerna seems to have some problem with elder yarn version. Therefore, I decided to bootstrap with npm by default instead of yarn. Once yarn has become more stable then correct the version.

@AllenFang AllenFang merged commit 9199484 into react-bootstrap-table:develop Sep 9, 2017
@AllenFang AllenFang mentioned this pull request Sep 17, 2017
@chunming-c chunming-c deleted the enhancement/environment branch October 8, 2017 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants