Set the disabled css class so that the text is greyed out.

[tannewt]

No description provided.

[jquense]

is this a feature from bootstrap? could you provide more context please?

[tannewt]

I think you could say that. This change makes the inner text of the dropdown match this less rule from Bootstrap: https://github.com/twbs/bootstrap/blob/master/less/navbar.less#L434

[taion]

Does this properly prevent the Dropdown button from being clicked?

[tannewt]

The click is already correctly prevented. This change only affects the appearance so that it looks disabled.

[taion]

Ah. Cool. LGTM. Need +1 reviewer.

[jquense]

I am a bit concerned that this is too implementation specific to go on the general Dropdown. would this present annoying styling resets for custom menus/toggles? Would it make more sense for the DropdownButton(s) to set it?

[taion]

Wouldn't that only be the case if they've defined a .disabled rule that would apply? Maybe I'm misunderstanding.

[taion]

@jquense ping

[AlexKVal]

Actually this is the fix for undiscovered, till now, bug.
@tannewt could you please add [fixed] into the beginning of your commit header ?
(it is then will be reflected in the Changelog)

Without this fix:

And with this fix:

and

[tannewt]

@AlexKVal Done.

[AlexKVal]

I presume we cannot merge it yet because of @jquense concern.
Will wait his comments on this.
🍒

[jquense]

I think my concern as abated for now. LGTM

[AlexKVal]

@tannewt thank you for your contribution 🍒

[tannewt]

Np! Happy to help.
On Mon, Sep 28, 2015 at 2:21 AM Alexander Shemetovsky <
notifications@github.com> wrote:

@tannewt https://github.com/tannewt thank you for your contribution [image:
🍒]

—
Reply to this email directly or view it on GitHub
#1295 (comment)
.