feat: added support for React Router 6 #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
upgrade-react-router
branch
from
38bf868 to
d32a260
Compare
mxschmitt
force-pushed
the
upgrade-react-router
branch
from
d32a260 to
a1d8282
Compare
mxschmitt
changed the title
kyletsang
approved these changes
Aug 27, 2020
| ...props | ||
| }) => { | ||
| const navigate = useNavigate(); | ||
| const href = useHref(typeof to === 'string' ? { pathname: to } : to); |
There was a problem hiding this comment.
I think we can just pass to here as is? Looks like useHref will parse both object and string forms.
|
I'm not well equipped to review this since i don't use react-router! |
Then I would say let's wait if more users request that change and then decide to ship it. |
Closed
|
@kyletsang anything else required to change in this PR or shall we follow-up with something? |
|
I think this should be good. I'll play around with it after it's merged and see if there's anything extra to add. Thanks for making all these changes! |
kyletsang
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it was worth it.
There were quite a lot of changes in React router 6: https://github.com/ReactTraining/react-router/blob/dev/docs/advanced-guides/migrating-5-to-6.md
Fixes #259
We would need a minor release after that since <6 seem to be not supported anymore.