Allow the v6 branch to be installed with npm using the github url #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam2schwab
changed the title
|
This would provide a temporary fix for #259. @mxschmitt I am new to contributing to open-source, is there something more i need to do before this gets reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use react-router v6 beta in my project and be able to use react-router-bootstrap along with it so I tweaked with the package.json file to allow the package to be installed from the GitHub URL. It makes use of the prepare npm script as explained in the npm docs and here.
This PR would allow others to use the react-router-bootstrap version that is compatible with react-router v6 without having to fork it and do the same modifications as I did or uploading it to npm.