Remove 'classnames' dependency as a result of refactoring. #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice. LGTM. Maybe rename the method to |
Address eslint warnings. DRY refactor the code. Move all general logic into mixin. `LinkMixin` is not a public API in `src/index.js` therefore `getClassName()` method is not public too and because it is used nowhere it has been removed. And as a consequence `classnames` dependency has been removed also.
Sure. 👍 |
Closed
taion
added a commit
that referenced
this pull request
Jun 18, 2015
Remove 'classnames' dependency as a result of refactoring.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address eslint warnings.
DRY refactor the code. Move all general logic into mixin.
As a sidenote: the main logic of this project is in the
LinkMixinmixin now.LinkMixinis not a public API insrc/index.jstherefore
getClassName()method is not public tooand because it is used nowhere it has been removed.
And as a consequence
classnamesdependency has been removed also.Closes #75