Skip to content

Conversation

AlexKVal
Copy link
Member

eslint
karma-cli

eslint
karma-cli
@AlexKVal
Copy link
Member Author

Should we release next version ?
There are some commits after Jun 13, 2015.

@mtscout6
Copy link
Member

mtscout6 commented Jul 6, 2015

LGTM

And yes a release sounds fine to me.

@AlexKVal
Copy link
Member Author

AlexKVal commented Jul 6, 2015

@taion would you release next version ? 😃

AlexKVal added a commit that referenced this pull request Jul 6, 2015
Update dev-dependencies.
@AlexKVal AlexKVal merged commit f3c0b19 into react-bootstrap:master Jul 6, 2015
@AlexKVal AlexKVal deleted the deps branch July 6, 2015 18:34
@taion
Copy link
Member

taion commented Jul 6, 2015

Been travelling and have had somewhat limited time to keep up. I can release if needed though - which branch and what version?

@AlexKVal
Copy link
Member Author

AlexKVal commented Jul 7, 2015

Emm.. there is only one branch at this project react-router-bootstrap, so then it will be just next version. Isn't it ?

@taion
Copy link
Member

taion commented Jul 7, 2015

Apologies - I thought this was the other repo. Do you want v0.16.1 or v0.17.0?

@AlexKVal
Copy link
Member Author

AlexKVal commented Jul 7, 2015

I'm looking through the last commits history and there are basically dev-dependencies updates
that don't affect the code generated.

And there is only this Remove 'classnames' dependency as a result of refactoring #76 changing the code patch.
In spite of that classnames is not a dependency now, it wasn't in use anyway till that change.

But.. I don't know how other developers were using or not that not public API removed code.
I propose: Let's do it safely: v0.17.0

@taion
Copy link
Member

taion commented Jul 8, 2015

We have v0.17.1 now (I messed up the Bower release for v0.17.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants