Skip to content

feat: improve hovering experience #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 23, 2020
Merged

feat: improve hovering experience #106

merged 6 commits into from
Jul 23, 2020

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented Jul 22, 2020

#25050

@afc163 @zombieJ

试试功能有没有问题，没问题晚上回去我把测试补上。

@vercel
Copy link

vercel bot commented Jul 22, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/picker/edlv1rsb4
✅ Preview: https://picker-git-fork-kermit-xuan-feat-25050.react-component.vercel.app

zombieJ
zombieJ reviewed Jul 22, 2020
View reviewed changes
@kerm1it
Copy link
Member Author

kerm1it commented Jul 22, 2020 •
edited
Loading

本地编译成功了，不知道为啥CI中失败了，看错误是 day.js 中声明有错误，但是我本地是正常的。

我暂时先把 dayjs 中的 parseLocale 返回值改为 any。

@codecov
Copy link

codecov bot commented Jul 23, 2020 •
edited
Loading

Codecov Report

Merging #106 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   99.57%   99.58%           
=======================================
  Files          43       44    +1     
  Lines        1902     1920   +18     
  Branches      578      583    +5     
=======================================
+ Hits         1894     1912   +18     
  Misses          6        6           
  Partials        2        2
Impacted Files Coverage Δ
src/hooks/useValueTexts.ts 100.00% <ø> (ø)
src/Picker.tsx 100.00% <100.00%> (ø)
src/RangePicker.tsx 100.00% <100.00%> (ø)
src/generate/dayjs.ts 100.00% <100.00%> (ø)
src/hooks/useHoverPlaceholder.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead450f...b8a9af0. Read the comment docs.

zombieJ
zombieJ reviewed Jul 23, 2020
View reviewed changes
zombieJ
zombieJ reviewed Jul 23, 2020
View reviewed changes
zombieJ
zombieJ reviewed Jul 23, 2020
View reviewed changes
@zombieJ zombieJ merged commit fd4b290 into react-component:master Jul 23, 2020
@zombieJ
Copy link
Member

zombieJ commented Jul 23, 2020

+ rc-picker@1.13.0

@kerm1it kerm1it deleted the feat-25050 branch July 23, 2020 13:34
afc163
afc163 reviewed Aug 5, 2020
View reviewed changes
src/generate/dayjs.ts
const parseLocale = (locale: string) => {
const mapLocale = localeMap[locale];
return mapLocale || locale.split('_')[0];
return (mapLocale || locale.split('_')[0]) as LocalePresetType;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci 报错了。

src/generate/dayjs.ts(38,49): error TS2304: Cannot find name 'LocalePresetType'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

估计 dayjs 又改了 = =

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@zombieJ zombieJ zombieJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kerm1it @zombieJ @afc163