generated from react-component/footer
-
-
Notifications
You must be signed in to change notification settings - Fork 334
feat: improve hovering experience #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
dff680f
feat: improve hovering experience
kerm1it 2473a4e
chore: remove raf of useHoverPlaceholder
kerm1it 292401b
test: add case for hover placeholder
kerm1it 620f8fb
fix: dayjs type error
kerm1it 164b331
chore: optimize logic
kerm1it b8a9af0
chore(day.js): fix parseLocale type
kerm1it File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { useState } from 'react'; | ||
import useValueTexts, { ValueTextConfig } from './useValueTexts'; | ||
|
||
export default function useHoverPlaceholder<DateType>( | ||
placeholder: string, | ||
text: string, | ||
{ formatList, generateConfig, locale }: ValueTextConfig<DateType>, | ||
): [string, (date: DateType) => void, (date: DateType) => void] { | ||
const [value, setValue] = useState(null); | ||
|
||
const [valueTexts] = useValueTexts(value, { | ||
formatList, | ||
generateConfig, | ||
locale, | ||
}); | ||
|
||
function onEnter(date: DateType) { | ||
if (!text) { | ||
setValue(date); | ||
} | ||
} | ||
|
||
function onLeave() { | ||
setValue(null); | ||
} | ||
|
||
return [(valueTexts && valueTexts[0]) || placeholder, onEnter, onLeave]; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci 报错了。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
估计 dayjs 又改了 = =