Skip to content

Conversation

saeedrahimi
Copy link
Contributor

I've just implemented rtl direction in rc-picker component

  • demo provided
  • test added
  • document updated

@vercel
Copy link

vercel bot commented Nov 30, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/picker/ip8kkj0ug
🌍 Preview: https://picker-git-fork-saeedrahimi-master.react-component.now.sh

@saeedrahimi
Copy link
Contributor Author

@zombieJ , just delivered before December 1 ;)

@zombieJ
Copy link
Member

zombieJ commented Dec 3, 2019

@saeedrahimi , Designer update the interactive logic of RangePicker. I'm still working on update this. Thanks for your quick update.

@zombieJ
Copy link
Member

zombieJ commented Dec 3, 2019

ref: #9

@saeedrahimi
Copy link
Contributor Author

Alright, could you please notice me to update this pull request when the breaking changes done?

@zombieJ
Copy link
Member

zombieJ commented Dec 4, 2019

Yes. I will leave message here when finished. Thanks~

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 12, 2019

This pull request introduces 1 alert when merging 1839a92 into 2426063 - view on LGTM.com

new alerts:

  • 1 for Overwritten property

@zombieJ
Copy link
Member

zombieJ commented Dec 12, 2019

Strange, why CI not check on this...

@zombieJ
Copy link
Member

zombieJ commented Dec 12, 2019

hi @saeedrahimi , I run npm test seems failed. Please check.

@saeedrahimi
Copy link
Contributor Author

@zombieJ
All Green ;)

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #6 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #6      +/-   ##
=========================================
+ Coverage   99.09%   99.1%   +<.01%     
=========================================
  Files          39      39              
  Lines        1660    1670      +10     
  Branches      519     526       +7     
=========================================
+ Hits         1645    1655      +10     
  Misses         10      10              
  Partials        5       5
Impacted Files Coverage Δ
src/PickerPanel.tsx 100% <ø> (ø) ⬆️
src/RangePicker.tsx 100% <100%> (ø) ⬆️
src/PickerTrigger.tsx 100% <100%> (ø) ⬆️
src/Picker.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b1061c...07b8957. Read the comment docs.

@zombieJ zombieJ merged commit dc9ac0f into react-component:master Dec 19, 2019
@zombieJ
Copy link
Member

zombieJ commented Dec 19, 2019

+ rc-picker@0.0.1-alpha.59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants