Skip to content

Conversation

KALrious
Copy link
Contributor

@KALrious KALrious commented Jan 6, 2020

#598

* follow the issue react-component#598
* add the possibility to add a get container method to fix the relative parent of the slider's tooltip
@codecov
Copy link

codecov bot commented Jan 6, 2020

Codecov Report

Merging #615 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #615   +/-   ##
======================================
  Coverage    95.4%   95.4%           
======================================
  Files           2       2           
  Lines          87      87           
  Branches       29      29           
======================================
  Hits           83      83           
  Misses          4       4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba4181...70a34c3. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Jan 9, 2020

Could you help to add an test case on this?

@KALrious
Copy link
Contributor Author

KALrious commented Jan 9, 2020

yeah of course, I can try :)

@KALrious
Copy link
Contributor Author

I try something but the thing is I don't know how tot test the use case where the tooltip is specially attach to a special node ancestor ...
If you have any idea ?

@zombieJ
Copy link
Member

zombieJ commented Jan 22, 2020

@KALrious
Copy link
Contributor Author

not sure about this test ... have try something with popupDomNode.parentNode.parentNode.parentNode instanceof HTMLDivElement``
But wasn't able to find the Trigger component from the createSliderWithTooltip

@zombieJ
Copy link
Member

zombieJ commented Jan 28, 2020

Seems file prettiered with other style. Please help to clean back.

@zombieJ zombieJ merged commit e11444e into react-component:master Feb 3, 2020
tipFormatter(value) { return value; },
handleStyle: [{}],
tipProps: {},
getTooltipContainer: node => node.parentNode,
Copy link
Member

@afc163 afc163 Feb 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better not since use getTooltipContainer will beak overflow hidden. #20699 is aim to compatible with origin behavior

@KALrious KALrious deleted the issue-598 branch February 3, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants