Skip to content

Conversation

bailitugesu
Copy link

…来一起滑动并一起离开屏幕,那么滑动的界面会卡在只有一根手指滑动时的画面,无法再滑动(此时left或者right展示部分,没有open),更严重的是如果按钮没有设置autoClose,便再也无法复原初始状态,设置了的话可以通过点击按钮复原。其中原因就是因为gesture中checkIfSingleTouchMove检测到两根手指变不再会执行onPanEnd,只会执行onPancancel,所以需要格外设置onPanCancel.

when you touch one finger on the SwipeOut and move your finger , it will trigger onPanStart and onPanMove and works fine, but when you put another finger on and move meanwhile, and suddenly move out your two finger, the SwipeOut will get stucked, and can't be swiped anymore, especilly when you don't set autoClose, it will not go back to the initial state anymore except to reload. The reason is that when gesture's function checkIfSingleTouchMove detectd multifinger and will not trigger onPanEnd anymore , instead it trigger onPanCancel, so we need to set onPanCancel additionally.
fix bug when swipeout can't trigger onPanEnd, and swipeout can't work normally anymore.

…来一起滑动并一起离开屏幕,那么滑动的界面会卡在只有一根手指滑动时的画面,无法再滑动(此时left或者right展示部分,没有open),更严重的是如果按钮没有设置autoClose,便再也无法复原初始状态,设置了的话可以通过点击按钮复原。其中原因就是因为gesture中checkIfSingleTouchMove检测到两根手指变不再会执行onPanEnd,只会执行onPancancel,所以需要格外设置onPanCancel.

when you touch one finger on the SwipeOut and move your finger , it will trigger onPanStart and onPanMove and works fine, but when you put another finger on and move  meanwhile, and suddenly move out your two finger, the SwipeOut will get stucked, and can't be swiped anymore, especilly when you don't set autoClose, it will not go back to the initial state anymore except to reload.  The reason is that when gesture's function checkIfSingleTouchMove detectd multifinger and will not trigger onPanEnd anymore , instead it trigger onPanCancel, so we need to set onPanCancel additionally.
fix bug when swipeout can't trigger onPanEnd, and swipeout can't  work normally anymore.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.741% when pulling 3f2fbc1 on bailitugesu:master into 2b23a99 on react-component:master.

@quentinyang
Copy link
Contributor

@bailitugesu thanks for your issue and PR. We have fixed it in #55.

@quentinyang quentinyang self-requested a review June 4, 2018 08:15
@quentinyang quentinyang closed this Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants