Add onCellClick for th and column key as argument #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. if user wants to to make the entire cell a target for sort toggle
covers th and td
make it easier to identify the exact cell clicked.
jlc467
changed the title
yesmeck
reviewed
Nov 14, 2016
| }; | ||
| if (column.onCellClick) { | ||
| cell.onClick = (e) => column.onCellClick(column, column.key, e); | ||
| } |
There was a problem hiding this comment.
I think the original purpose of onCellClick is only applying to the body cell. If we want apply onCellClick to header cell as well, we should keep the arguments consistent.
/cc @afc163
|
It seems material-ui only applies onCellClick to body cell too. https://github.com/callemall/material-ui/blob/f2edf58f6e1683ce26f5046ce05a6c9e83b60928/src/Table/Table.js#L159-L186 |
|
Actually, you already know which column occurs event because you are defining onCellClick on that column. |
This reverts commit 5be42e5.
|
Will close this for now. If there is demand we can add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if user wants to trigger sort behavior on any click within the
th. Can use event to filter unwanted clicks, e.g. filter menu or specific sort direction arrow.Downside is, within
onCellClick, user can't always assume it is a body cell anymore, though It is easy enough to tell the difference between body and head cells.Also, column key helps user determine the actual cell clicked. As of now, we just know the row and must use the event to know cell. Alternatively, give the user the row and column index like material-ui