enhance: Rm duplicated re-render of expanded row #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #1022 +/- ##
==========================================
- Coverage 99.41% 99.41% -0.01%
==========================================
Files 47 47
Lines 4430 4426 -4
Branches 561 559 -2
==========================================
- Hits 4404 4400 -4
Misses 26 26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yoyo837
reviewed
Sep 18, 2023
| const [expandRended, setExpandRended] = React.useState(false); | ||
| // Force render expand row if expanded before | ||
| const expandedRef = React.useRef(false); | ||
| expandedRef.current ||= expanded; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
更标准的解法应该是
useState在关闭时一起做 state 更新，但是这样会让渲染逻辑变得过于复杂。只为了少一次渲染会变得缺少性价比。close ant-design/ant-design#44890