Skip to content

fix: run in node before not ready #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2023
Merged

fix: run in node before not ready #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
573d573
fix: run in node
zombieJ Sep 24, 2023
8127fd2
test: add test case
zombieJ Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ function Table<RecordType extends DefaultRecordType>(tableProps: TableProps<Reco

const onFullTableResize = ({ width }) => {
let mergedWidth = fullTableRef.current ? fullTableRef.current.offsetWidth : width;
if (useInternalHooks && getContainerWidth) {
if (useInternalHooks && getContainerWidth && fullTableRef.current) {
mergedWidth = getContainerWidth(fullTableRef.current, mergedWidth) || mergedWidth;
}

Expand Down Expand Up @@ -669,7 +669,7 @@ function Table<RecordType extends DefaultRecordType>(tableProps: TableProps<Reco
</FixedHolder>
)}

{isSticky && scrollBodyRef.current instanceof Element && (
{isSticky && scrollBodyRef.current && scrollBodyRef.current instanceof Element && (
<StickyScrollBar
ref={stickyRef}
offsetScroll={offsetScroll}
Expand Down
23 changes: 23 additions & 0 deletions tests/Node.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import React from 'react';
import { renderToString } from 'react-dom/server';
import Table from '../src';

describe('Table.Node', () => {
// Remove env variables
window.Element = null;
global.Element = null;

it('not crash in node', () => {
console.log(Element);

const html = renderToString(
<Table
columns={[{ title: 'Name', dataIndex: 'name', key: 'name' }]}
data={[{ key: 'key0', name: 'Lucy' }]}
sticky
/>,
);

expect(html).toContain('rc-table');
});
});