Skip to content

Conversation

queimadus
Copy link
Contributor

This PR optimizes the row expanding procedure and deal better with rendering React components in the expandedRowRender function by:

  • reducing the number of calls to determine if the same row is expanded inside the same render,
  • only calling the expandedRowRender function when the row is expanded.
    • this way, a react component mounted here will have the componentDidMount and componentWillUnmount methods correctly called.

It also, fixes an linting error present in the master branch

@yiminghe
Copy link
Member

thanks

yiminghe added a commit that referenced this pull request Oct 27, 2015
@yiminghe yiminghe merged commit d0c2ca4 into react-component:master Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants