Use component-classes for className manipulation #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesmeck
force-pushed
the
introcude-component-classes
branch
from
5bf2e8a to
49e74f5
Compare
yesmeck
force-pushed
the
introcude-component-classes
branch
from
49e74f5 to
828ccee
Compare
afc163
reviewed
Feb 6, 2017
src/Table.jsx
Outdated
| if (this.tableNode) { | ||
| const { prefixCls } = this.props; | ||
| classes(this.tableNode).remove(new RegExp(`^${prefixCls}-scroll-position-.+$`)); | ||
| classes(this.tableNode).add(`${prefixCls}-scroll-position-${position}`); |
This patch improve table horizontal scroll performance, #4631
afc163
reviewed
Feb 6, 2017
| className += ` ${prefixCls}-fixed-header`; | ||
| } | ||
| className += ` ${prefixCls}-scroll-position-${this.state.scrollPosition}`; | ||
| className += ` ${prefixCls}-scroll-position-${this.scrollPosition}`; |
There was a problem hiding this comment.
There was a problem hiding this comment.
应该说不写的话，一 render 设置的 class 就没了。
yesmeck
force-pushed
the
introcude-component-classes
branch
from
828ccee to
f92e86c
Compare
afc163
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves table horizontal scroll performance, ant-design/ant-design#4631