fix: should not rely on z-index #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjycui
commented
Feb 22, 2017
| position: absolute; | ||
| top: 0; | ||
| overflow: hidden; | ||
| z-index: 1; |
There was a problem hiding this comment.
z-index 很容易失控。 see: ant-design/ant-design@e289ce8#commitcomment-20987006
benjycui
commented
Feb 22, 2017
| {this.getEmptyText()} | ||
| {this.getFooter()} | ||
| </div> | ||
| {this.columnManager.isAnyColumnsLeftFixed() && |
There was a problem hiding this comment.
调整之后的 DOM 结构也更加合理，因为 fixed 的只是附加内容，主内容应该在前面。
benjycui
referenced
this pull request
in ant-design/ant-design
Feb 22, 2017
|
Snapshot 故意不提交，为了方便 review |
afc163
approved these changes
Feb 22, 2017
|
提交下我合并掉。 |
|
Updated. |
afc163
added a commit
to ant-design/ant-design
that referenced
this pull request
Feb 23, 2017
BANG88
pushed a commit
to ant-design/ant-design
that referenced
this pull request
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
antd 本地可重现 http://127.0.0.1:8001/components/table/#components-table-demo-fixed-columns-header