fix: Table header layout when data is empty #1330
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a layout issue with sticky table headers that occurred when the table data was empty. The fix involves introducing a new prop to provide more granular control over the styling of the internal table element within the fixed header, ensuring correct display in such scenarios. An example demonstrating this improvement has also been added.
Highlights
- Table Header Layout Fix: Addresses an issue where sticky table headers had incorrect layout when the table data was empty, ensuring proper rendering.
- New
scrollTableStyleProp: Introduced a newscrollTableStyleprop toFixedHeaderPropswhich allows custom CSS properties to be applied directly to the internal table element within the fixed header, providing more styling control. - Snapshot Updates: Updated test snapshots to reflect the new
widthandmin-widthstyles applied to table headers, confirming the visual correction. - New Example: Added a new example in
stickyHeader.tsxto demonstrate the fixed behavior of sticky headers with empty data, making the solution verifiable. - Version Bump: Incremented the package version from
7.52.1to7.52.2, indicating a new release with this fix.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #1330 +/- ##
=========================================
Coverage 97.74% 97.74%
=========================================
Files 77 77
Lines 7623 7626 +3
Branches 1154 1154
=========================================
+ Hits 7451 7454 +3
Misses 166 166
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue with table header layout when the data is empty by passing scrollTableStyle to the FixedHolder. This ensures the header table has the correct width. However, I've identified a related issue where the tableLayout for the fixed header is hardcoded, which can cause layout inconsistencies when using scroll.x: 'max-content'. My review includes a suggestion to address this for a more robust fix.
ant-design/ant-design#31494