fix: insert header content into body measure rows for column width calculation #1331
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #1331 +/- ##
=========================================
Coverage 97.74% 97.74%
=========================================
Files 77 77
Lines 7626 7641 +15
Branches 1154 1156 +2
=========================================
+ Hits 7454 7469 +15
Misses 166 166
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
此拉取请求旨在解决表格列宽计算不准确的问题，特别是当表格主体内容比表头文本短时，可能导致表头列被错误压缩。通过调整表格内部测量行中列标题的渲染方式，确保列宽能够准确地根据表头内容进行测量。
Highlights
- 列宽计算修复: 修复了当表格内容少于表头内容时，表头列宽被挤压的问题。
- 解决方案: 解决方案是将
column.title渲染到MeasureRow -> MeasureCell中，以确保在计算列宽时考虑表头内容。 - 问题关联: 此修复解决了多个相关问题，包括 #53829, #51394, #42713。
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
本次 PR 通过在测量行中渲染表头内容，解决了当单元格内容比表头短时列宽计算不正确的问题，这个解决方案是合理的。此外，还对 FixedHolder 组件进行了重构，使其 tableLayout 可配置，提高了灵活性。
代码审查发现了一些可以改进的地方：
MeasureRow.tsx中存在一个性能问题，可以通过使用Map来优化列的查找。MeasureRow.tsx中的 props 接口命名可以改进，以提高代码清晰度。MeasureCell.tsx中的样式可能会导致测量不准确。
具体的修改建议请见下面的评论。
|
表头合并单元格怎么办？ |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
加了一个 demo，看上去没问题： 
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a table layout issue where header columns get compressed when table content is shorter than header content. The solution inserts header content into hidden measure rows to ensure proper column width calculation.
- Adds header titles to measure cells for accurate width calculation
- Modifies styles in measure rows to accommodate header content rendering
- Updates component interfaces to pass column data through to measure components
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Body/MeasureCell.tsx | Renders column titles in measure cells with bold font weight |
| src/Body/MeasureRow.tsx | Passes column data to measure cells and removes font-size: 0 styling |
| src/Body/index.tsx | Forwards flattenColumns prop to MeasureRow component |
| src/FixedHolder/index.tsx | Adds tableLayout prop support for fixed table holders |
| src/Table.tsx | Passes tableLayout prop to fixed holders |
| tests/snapshots/*.snap | Updates test snapshots to reflect new measure row styling |
| docs/examples/stickyHeader.tsx | Adds test cases for grouped columns and edge cases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
解决内容比表头内容少，导致表头列宽度被挤压的问题。
解决方式：将 column.title 放到 body 里，具体是 MeasureRow -> MeasureCell 里渲染，参考 @crazyair 的解法 ant-design/ant-design#54741 (comment)
ant-design/ant-design#53829
ant-design/ant-design#51394
ant-design/ant-design#42713
效果：
修复前：
修复后：