fix: Table columns minWidth props no work when virtualized (for 5.x) #1337
Conversation
Co-authored-by: 路振凯 <l>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @yoyo837, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request integrates a critical fix for the antd@5.x branch, specifically addressing an issue where the minWidth property of table columns was not functioning correctly in virtualized tables. The change ensures that column widths are accurately calculated, respecting the minWidth constraint, which improves the layout and responsiveness of virtualized data tables.
Highlights
- Virtualized Table Columns: Corrected an issue where the minWidth property was not being applied to table columns when virtualization was enabled, ensuring proper column sizing.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #1337 +/- ##
=========================================
Coverage 97.75% 97.75%
=========================================
Files 77 77
Lines 7658 7659 +1
Branches 1160 1161 +1
=========================================
+ Hits 7486 7487 +1
Misses 166 166
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the minWidth prop on table columns was not being applied when using a virtualized table. The change correctly computes the column width by taking the maximum of the provided width and minWidth. My review includes a suggestion to improve the robustness of the type conversion from width and minWidth to numbers, to avoid potential NaN values that could break the layout.
| total += width as number; | ||
| return [key, width as number, total]; | ||
| return flattenColumns.map(({ width, minWidth, key }) => { | ||
| const finalWidth = Math.max((width as number) || 0, (minWidth as number) || 0); |
There was a problem hiding this comment.
While this change correctly introduces minWidth and handles undefined values, the use of as number can be unsafe if width is a string that cannot be cleanly coerced to a number (e.g., '100px'). This would result in NaN from Math.max.
A safer approach is to explicitly convert to a number. This will gracefully handle non-numeric strings by evaluating them to 0 in the Math.max function, preventing NaN values.
const finalWidth = Math.max(Number(width) || 0, Number(minWidth) || 0);
Cherry-pick #1334 for
antd@5.x