fix: Table column align issue when scroll.x is true #1341
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @afc163, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a critical bug in the Table component that caused column misalignment when horizontal scrolling was active. The changes ensure that table headers and body columns align correctly, significantly improving the rendering and user experience for tables with extensive data.
Highlights
- Table Column Alignment Fix: Resolved an issue where table columns would misalign when horizontal scrolling (
scroll.x) was enabled, ensuring consistent layout for wide tables. - CSS Property Adjustments: Modified CSS properties for table cells and table width calculations to correctly handle horizontal scrolling and prevent layout inconsistencies.
- ColGroup Rendering Optimization: Updated the
ColGroupcomponent to conditionally render the<colgroup>element only when necessary, avoiding the rendering of empty tags. - New Example Cases: Added new examples to the documentation to demonstrate and verify the fix for the
scroll.xcolumn alignment issue.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a table column alignment issue that occurs when the scroll.x property is set to true. The fix addresses misaligned columns in tables with horizontal scrolling enabled.
- Modifies table styling to properly handle column alignment when horizontal scrolling is enabled
- Removes unnecessary empty
colgroupelements from the rendered output - Updates style property ordering for consistency across table elements
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Table.tsx | Changes passed props to FixedHolder from scrollTableStyle to scrollX |
| src/FixedHolder/index.tsx | Updates prop handling and table styling logic for horizontal scroll scenarios |
| src/ColGroup.tsx | Adds conditional rendering to avoid empty colgroup elements |
| docs/examples/stickyHeader.tsx | Adds test case demonstrating the scroll.x=true scenario |
| docs/examples/scrollY.tsx | Adds test case for column alignment issue |
| assets/index.less | Removes word-break styling that may affect alignment |
| Multiple test snapshots | Updates expected output to reflect changes in rendering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request addresses a column alignment issue in the Table component when scroll.x is set to true. The fix involves several changes:
- In
FixedHolder/index.tsx, the logic for setting the table width is adjusted to correctly handle horizontal scrolling. - The
word-break: break-word;style is removed fromassets/index.lessto prevent text wrapping from interfering with column alignment. - The
ColGroupcomponent is improved to avoid rendering an empty<colgroup>tag, which also cleans up test snapshots. - New examples and tests have been added to cover the fixed scenario.
My review has identified a critical issue in FixedHolder/index.tsx where the logic for scroll.x: true is not correctly handled, which could lead to layout problems. I've also noted a minor typo in an issue link in one of the example files and a type-casting issue that could be improved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## antd-5.x #1341 +/- ##
=========================================
Coverage 97.75% 97.75%
=========================================
Files 77 77
Lines 7659 7660 +1
Branches 1161 1162 +1
=========================================
+ Hits 7487 7488 +1
Misses 166 166
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
close ant-design/ant-design#54894