Table scroll 问题。修复。 #152
Closed
Table scroll 问题。修复。 #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
可以在 Firefox 下看下 http://127.0.0.1:8000/examples/fixedColumnsAndHeader.html 这个例子，滚动中间区域时会有剧烈的抖动。master 则没有这个问题。 |
|
看了下，是 rc-table-header 的 scrollTop = 0 触发了抖动问题。 所以就把 handleBodyScroll 分成 handleBodyScrollLeft 和 handleBodyScrollTop 。 rc-table-header 元素只绑定 handleBodyScrollLeft 操作。 测试了 win 的 ie / chrome/ firefox ，mac 的 chrome /safari / firefox 。 看了下，没啥问题。 |
|
Merged in 7be6497 |
shenqihui
added a commit
to pchange/ant-design
that referenced
this pull request
Jul 24, 2017
Desc at ant-design#6537 . Fix at react-component/table#152 and publish at rc-table 5.4.2 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前遇到scroll的问题。
见 ant-design/ant-design#6537。
目前测试 横向纵向 scroll 都没问题，mac + win 测过没问题。
旧的 pr 在 #147
if (e.target !== this.scrollTarget) 的判断，加了这个判断的话，假设会避免 scrollTop 的循环触发的问题，那应该能够通过存储 this.lastScrollTop 来避免。所以 scrollTarget 应该不用判断了。