Skip to content

Conversation

saeedrahimi
Copy link
Contributor

Just added some fixes for rtl direction.
Fixed columns in rtl direction will be displayed correctly with these changes.

@vercel
Copy link

vercel bot commented Mar 4, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/table/prjj86my9
✅ Preview: https://table-git-fork-saeedrahimi-fix-rtl.react-component.now.sh

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #426 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   99.83%   99.84%   +<.01%     
==========================================
  Files          21       21              
  Lines         601      629      +28     
  Branches      167      181      +14     
==========================================
+ Hits          600      628      +28     
  Misses          1        1
Impacted Files Coverage Δ
src/Cell/index.tsx 98.21% <ø> (-0.07%) ⬇️
src/context/TableContext.tsx 100% <ø> (ø) ⬆️
src/Header/HeaderRow.tsx 100% <100%> (ø) ⬆️
src/Header/FixedHeader.tsx 100% <100%> (ø) ⬆️
src/Table.tsx 100% <100%> (ø) ⬆️
src/hooks/useColumns.tsx 100% <100%> (ø) ⬆️
src/utils/fixUtil.ts 100% <100%> (ø) ⬆️
src/hooks/useStickyOffsets.ts 100% <100%> (ø) ⬆️
src/Body/BodyRow.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507c044...da83ead. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Mar 5, 2020

Could you help to add a test case to test related class?

@saeedrahimi
Copy link
Contributor Author

Could you help to add a test case to test related class?

I've added some tests. ;)

@saeedrahimi
Copy link
Contributor Author

@zombieJ I don't know why FixTitle3 is not working even in LTR direction.
..
also tested on master branch and still not working.
.
Code coverage fails beacause of this line:
https://codecov.io/gh/react-component/table/pull/426/src/src/hooks/useColumns.tsx#L97
and if its not mandatory i remove children from revertForRtl function.

@zombieJ
Copy link
Member

zombieJ commented Mar 6, 2020

Excuse me. What is FixTitle3?

@saeedrahimi
Copy link
Contributor Author

Excuse me. What is FixTitle3?

Capture

Title 3 fixed column doesn't work.

{
title: 'title3',
fixed: fixLeft && fixTitle ? 'left' : null,
children: [
{ title: 'title4', dataIndex: 'c', key: 'd', width: 100 },
{ title: 'title5', dataIndex: 'c', key: 'e', width: 100 },
],

@saeedrahimi
Copy link
Contributor Author

All green now, and i think Fixed Title 3 should be handled in another issue.

@zombieJ zombieJ merged commit 6986eb9 into react-component:master Mar 7, 2020
@zombieJ
Copy link
Member

zombieJ commented Mar 7, 2020

+ rc-table@7.3.0

Please help to added in antd@feature brach : )

@saeedrahimi
Copy link
Contributor Author

saeedrahimi commented Mar 7, 2020

+ rc-table@7.3.0

Please help to added in antd@feature brach : )

I'm fixing antd table bug on master branch and i need these changes. , should i move it to feature branch?

@saeedrahimi saeedrahimi deleted the fix-rtl branch March 7, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants