feat: Fixed Summary columns #618

zombieJ · 2021-05-21T02:42:01Z

Follow up of #503

close #503
close ant-design/ant-design#25116
ref ant-design/ant-design#23170
ref ant-design/ant-design#5710
ref ant-design/ant-design#14795

👁 Preview

vercel · 2021-05-21T02:42:04Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/table/39oAB5YKd2obUNV7wd2Ft8u2zFqV
✅ Preview: https://table-git-fix-summary-react-component.vercel.app

codecov · 2021-05-21T03:06:47Z

Codecov Report

Merging #618 (0a05d46) into master (3899381) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0a05d46 differs from pull request most recent head 2f5e6a7. Consider uploading reports for the commit 2f5e6a7 to get more accurate results

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   99.75%   99.76%           
=======================================
  Files          26       27    +1     
  Lines         817      850   +33     
  Branches      231      256   +25     
=======================================
+ Hits          815      848   +33     
  Misses          2        2

Impacted Files	Coverage Δ
src/Header/Header.tsx	`100.00% <ø> (ø)`
src/FixedHolder/index.tsx	`100.00% <100.00%> (ø)`
src/Footer/Cell.tsx	`100.00% <100.00%> (ø)`
src/Footer/Row.tsx	`100.00% <100.00%> (ø)`
src/Footer/Summary.tsx	`100.00% <100.00%> (ø)`
src/Footer/index.tsx	`100.00% <100.00%> (ø)`
src/Table.tsx	`100.00% <100.00%> (ø)`
src/hooks/useSticky.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3899381...2f5e6a7. Read the comment docs.

hemengke1997 · 2021-05-24T02:11:38Z

yo，终于更新了啊！牛逼牛逼

flyingcrp · 2021-05-24T06:16:15Z

Nice work

pierre-b · 2021-05-24T21:07:12Z

Thanks for the merge guys!!

flyingcrp · 2021-05-25T02:17:08Z

need upgrade document

hemengke1997 · 2021-05-25T02:20:09Z

need upgrade document

https://table-git-fix-summary-react-component.vercel.app/demo/sticky-header-and-summary

flyingcrp · 2021-05-25T02:25:35Z

need upgrade document

https://table-git-fix-summary-react-component.vercel.app/demo/sticky-header-and-summary

it's not work . im sure i got the "antd": "^4.16.0",
my code like this :


const TableSummary = ({columns, data, isSelect}) => {
    if (!Object.keys(data).length) return null;
    return (
        <Summary fixed >
            <Summary.Row>
                {isSelect && <Summary.Cell key={'selected-clm'} />}
                {columns.map((clm, idx) => {
                    if (idx === 0) {
                        return (
                            <Summary.Cell key={clm.dataIndex}>合</Summary.Cell>
                        );
                    }
                    if (!clm.children || !clm.children.length) {
                        return (
                            <Summary.Cell key={clm.dataIndex} align={clm.align}>
                                <ParseClm clm={clm} data={data} />
                            </Summary.Cell>
                        );
                    } else {
                        return clm.children.map((row) => {
                            return (
                                <Summary.Cell
                                    key={row.dataIndex}
                                    align={row.align}
                                >
                                    <ParseClm clm={row} data={data} />
                                </Summary.Cell>
                            );
                        });
                    }
                })}
            </Summary.Row>
        </Summary>
    );
};
export default TableSummary;

hemengke1997 · 2021-05-25T02:31:38Z

need upgrade document

https://table-git-fix-summary-react-component.vercel.app/demo/sticky-header-and-summary

it's not work . im sure i got the "antd": "^4.16.0",
my code like this :


const TableSummary = ({columns, data, isSelect}) => {
    if (!Object.keys(data).length) return null;
    return (
        <Summary fixed >
            <Summary.Row>
                {isSelect && <Summary.Cell key={'selected-clm'} />}
                {columns.map((clm, idx) => {
                    if (idx === 0) {
                        return (
                            <Summary.Cell key={clm.dataIndex}>合</Summary.Cell>
                        );
                    }
                    if (!clm.children || !clm.children.length) {
                        return (
                            <Summary.Cell key={clm.dataIndex} align={clm.align}>
                                <ParseClm clm={clm} data={data} />
                            </Summary.Cell>
                        );
                    } else {
                        return clm.children.map((row) => {
                            return (
                                <Summary.Cell
                                    key={row.dataIndex}
                                    align={row.align}
                                >
                                    <ParseClm clm={row} data={data} />
                                </Summary.Cell>
                            );
                        });
                    }
                })}
            </Summary.Row>
        </Summary>
    );
};
export default TableSummary;

what's wrong?

I used the nearly code and there is no error

flyingcrp · 2021-05-25T02:35:42Z

need upgrade document

https://table-git-fix-summary-react-component.vercel.app/demo/sticky-header-and-summary

it's not work . im sure i got the "antd": "^4.16.0",
my code like this :


const TableSummary = ({columns, data, isSelect}) => {
    if (!Object.keys(data).length) return null;
    return (
        <Summary fixed >
            <Summary.Row>
                {isSelect && <Summary.Cell key={'selected-clm'} />}
                {columns.map((clm, idx) => {
                    if (idx === 0) {
                        return (
                            <Summary.Cell key={clm.dataIndex}>合</Summary.Cell>
                        );
                    }
                    if (!clm.children || !clm.children.length) {
                        return (
                            <Summary.Cell key={clm.dataIndex} align={clm.align}>
                                <ParseClm clm={clm} data={data} />
                            </Summary.Cell>
                        );
                    } else {
                        return clm.children.map((row) => {
                            return (
                                <Summary.Cell
                                    key={row.dataIndex}
                                    align={row.align}
                                >
                                    <ParseClm clm={row} data={data} />
                                </Summary.Cell>
                            );
                        });
                    }
                })}
            </Summary.Row>
        </Summary>
    );
};
export default TableSummary;

what's wrong?

I used the nearly code and there is no error

yeah, ther is no error ,but .the summary row is also not stickied
so i dont know how to config it to showlike this merge

hemengke1997 · 2021-05-25T02:41:57Z

yeah, ther is no error ,but .the summary row is also not stickied
so i dont know how to config it to showlike this merge

allright, me too. maybe there is something we missed

hemengke1997 · 2021-05-25T02:49:22Z

@flyingcrp this is workable

flyingcrp · 2021-05-25T03:27:24Z

@flyingcrp this is workable

wow, is my code wrong?
let me see your code ,thanks

hemengke1997 · 2021-05-25T03:29:37Z

wow, is my code wrong?
let me see your code ,thanks

just like the example

summary={() => (
  <Table.Summary fixed={true}>
    <Table.Summary.Row>
      <Table.Summary.Cell index={0} />
      <Table.Summary.Cell index={1} colSpan={2}>
        Summary
      </Table.Summary.Cell>
      <Table.Summary.Cell index={3} colSpan={8}>
        Content
      </Table.Summary.Cell>
      <Table.Summary.Cell index={11} colSpan={2}>
        Right
      </Table.Summary.Cell>
    </Table.Summary.Row>
  </Table.Summary>
)}

hemengke1997 · 2021-05-25T03:30:24Z

wow, is my code wrong?
let me see your code ,thanks

maybe u should restart ur server after upgrade antd

qyuja · 2021-05-25T08:09:57Z

有办法把summary放到tbody上面固定吗

miristein · 2021-06-22T08:21:37Z

I had the same problem - adding index to each cell was the solution.

() => (
<Table.Summary fixed={true}>
    <Table.Summary.Row>
        <Table.Summary.Cell index={0}>
            <Typography.Text strong={true}>First pilot column</Typography.Text>
        </Table.Summary.Cell>
        <Table.Summary.Cell index={1}>
            Content
        </Table.Summary.Cell>
        <Table.Summary.Cell index={2}>
            Content
        </Table.Summary.Cell>
    </Table.Summary.Row>
    <Table.Summary.Row>
        <Table.Summary.Cell index={0}>
            <Typography.Text strong={true}>Second pilot column</Typography.Text>
        </Table.Summary.Cell>
        <Table.Summary.Cell index={1}>
            Content
        </Table.Summary.Cell>
        <Table.Summary.Cell index={2}>
            Content
        </Table.Summary.Cell>
    </Table.Summary.Row>
</Table.Summary>
)

zombieJ added 8 commits May 20, 2021 15:47

docs: demo driven

b5253e7

docs: Update demo

741c4fd

chore: Add Summary Sugar

5c6ec16

refactor: Use FixedHolder

ef3a199

chore: summary scrollable

2d0c448

chore: Patch last column scroll

354c6a9

fix: scrollbar summary

fbf3087

use context for passing

64df2cb

fix: basic bind scroll logic

fb71abe

vercel bot deployed to Preview May 21, 2021 02:44 View deployment

test: Fix test case

ea4a1c0

vercel bot deployed to Preview May 21, 2021 03:01 View deployment

feat: sticy summary

decd287

vercel bot deployed to Preview May 21, 2021 03:36 View deployment

chore: Fixed style

7a58db5

vercel bot deployed to Preview May 21, 2021 10:07 View deployment

test: Test coverage

0f17e7c

vercel bot deployed to Preview May 21, 2021 13:01 View deployment

test: Test coverage

4cfa657

vercel bot deployed to Preview May 21, 2021 13:24 View deployment

chore: Cleanup useless code

2f5e6a7

vercel bot deployed to Preview May 21, 2021 13:36 View deployment

zombieJ merged commit 3a70f59 into master May 24, 2021

zombieJ deleted the fix-summary branch May 24, 2021 02:09

hemengke1997 mentioned this pull request May 24, 2021

🧐[问题] rc-table更新了，请问pro-table对应功能啥时候能更新 ant-design/pro-components#2824

Closed

This was referenced Jun 3, 2021

table summary position (top / bottom) ant-design/ant-design#23170

Closed

[4.0]antd表格 summary 总结栏能够进行固定位置 ant-design/ant-design#20472

Closed

Uh oh!

feat: Fixed Summary columns #618

feat: Fixed Summary columns #618

Uh oh!

Conversation

zombieJ commented May 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👁 Preview

Uh oh!

vercel bot commented May 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hemengke1997 commented May 24, 2021

Uh oh!

flyingcrp commented May 24, 2021

Uh oh!

pierre-b commented May 24, 2021

Uh oh!

flyingcrp commented May 25, 2021

Uh oh!

hemengke1997 commented May 25, 2021

Uh oh!

flyingcrp commented May 25, 2021

Uh oh!

hemengke1997 commented May 25, 2021

Uh oh!

flyingcrp commented May 25, 2021

Uh oh!

hemengke1997 commented May 25, 2021

Uh oh!

hemengke1997 commented May 25, 2021

Uh oh!

flyingcrp commented May 25, 2021

Uh oh!

hemengke1997 commented May 25, 2021

Uh oh!

hemengke1997 commented May 25, 2021

Uh oh!

qyuja commented May 25, 2021

Uh oh!

miristein commented Jun 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zombieJ commented May 21, 2021 •

edited

Loading

vercel bot commented May 21, 2021 •

edited

Loading

codecov bot commented May 21, 2021 •

edited

Loading

miristein commented Jun 22, 2021 •

edited

Loading