Skip to content

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 1, 2016

Fix ant-design/ant-design#2540 and ant-design/ant-design#2454

Also improve perfermance for #35

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b4e6f1f on improve-table-row-cell-render into * on master*.

@afc163 afc163 force-pushed the improve-table-row-cell-render branch from b4e6f1f to 5383d4d Compare August 1, 2016 12:53
@afc163 afc163 changed the title split TableCell for better perfermance split TableRow and TableCell for better perfermance Aug 1, 2016
@afc163 afc163 merged commit fc7d242 into master Aug 1, 2016
@afc163 afc163 deleted the improve-table-row-cell-render branch August 1, 2016 12:54
onMouseEnter={props.onHover.bind(null, true, hoverKey)}
onMouseLeave={props.onHover.bind(null, false, hoverKey)}
className={`${prefixCls} ${props.className} ${prefixCls}-level-${indent}`}
onMouseEnter={onHover.bind(null, true, hoverKey)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看能不能不要每次 bind

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,这里不需要 bind 的。直接 onMouseEnter={() => onHover(true, hoverKey)}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是尽量不要在 render 中生成函数

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants