Skip to content

Conversation

hemengke1997
Copy link
Contributor

@hemengke1997 hemengke1997 commented Jan 6, 2022

修复表格空状态时 emptynode 未固定显示的问题

7.20.2之前,这里的传值是模糊的
image

7.20.2之后,在

if (fixColumn) {
改成了始终使用 ExpandedRowContext 中的 fixColumn,空状态时 fixColumnfalse,就造成了显示上的问题

@vercel
Copy link

vercel bot commented Jan 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/table/7M77fG6pZiSvfVvwKWHsnRGHdV9C
✅ Preview: https://table-git-fork-hemengke1997-fix-table-empty-react-component.vercel.app

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #730 (026b6e3) into master (b973d40) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #730   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          33       33           
  Lines         964      964           
  Branches      278      278           
=======================================
  Hits          958      958           
  Misses          6        6           
Impacted Files Coverage Δ
src/Body/BodyRow.tsx 97.91% <ø> (ø)
src/Body/index.tsx 100.00% <ø> (ø)
src/Table.tsx 99.17% <ø> (ø)
src/context/ExpandedRowContext.tsx 100.00% <ø> (ø)
src/Body/ExpandedRow.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b973d40...026b6e3. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Jan 7, 2022

问题是啥?给个重现?

@hemengke1997
Copy link
Contributor Author

@afc163
Copy link
Member

afc163 commented Jan 7, 2022

👍

@afc163
Copy link
Member

afc163 commented Jan 7, 2022

@afc163 afc163 merged commit d7413dd into react-component:master Jan 7, 2022
@afc163
Copy link
Member

afc163 commented Jan 7, 2022

我发个 patch,麻烦到 antd 里升级并测试一下,再发个 PR 过来。

@hemengke1997
Copy link
Contributor Author

我发个 patch,麻烦到 antd 里升级并测试一下,再发个 PR 过来。

emmm... 我不懂这个操作,以前没有搞过,可以教一下吗 😭

@afc163
Copy link
Member

afc163 commented Jan 7, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants