Skip to content

fix: receive an error warning when the direction is rtl #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2022
Merged

fix: receive an error warning when the direction is rtl #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37527eb
fix: receive an error warning when the direction is rtl
Dunqing May 5, 2022
9dd5405
fix: add test case
Dunqing May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hooks/useColumns.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ function useColumns<RecordType>(
}, [mergedColumns, direction]);
// Only check out of production since it's waste for each render
if (process.env.NODE_ENV !== 'production') {
warningFixed(flattenColumns);
warningFixed(direction === 'rtl' ? flattenColumns.slice().reverse() : flattenColumns);
}
return [mergedColumns, flattenColumns];
}
Expand Down
6 changes: 6 additions & 0 deletions tests/FixedColumn.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,11 @@ describe('Table.FixedColumn', () => {
"Warning: Index 2 of `columns` missing `fixed='right'` prop.",
);
});

it('RTL', () => {
mount(<Table columns={[{}, { fixed: 'right' }]} direction="rtl" />);
expect(errorSpy).not.toHaveBeenCalled();
});
});

it('ellipsis will wrap additional dom', () => {
Expand All @@ -207,6 +212,7 @@ describe('Table.FixedColumn', () => {
);
expect(wrapper.render()).toMatchSnapshot();
});

it('has correct scroll classNames when table direction is RTL', () => {
const wrapper = mount(<Table columns={columns} data={data} direction="rtl" />);

Expand Down