Skip to content

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Sep 9, 2016

原来用 CSS 的计算方式是有问题的,因为表头可能被里面的内容撑得超过 CSS 计算的高度。

另外有两个疑问:

  • 这里 什么情况下会有 row.getBoundingClientRect().height == false ?
  • 这里 为什么要用 setTimeout,这样会导致在测试里没法同步拿到设置的高度。

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 83.179% when pulling 4456886 on yesmeck:improve-columns-height into 6a5debb on react-component:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 83.919% when pulling 229790c on yesmeck:improve-columns-height into 6a5debb on react-component:master.

@afc163
Copy link
Member

afc163 commented Sep 9, 2016

  1. 有点忘了,可能是表格或表头被隐藏的时候?

@afc163 afc163 merged commit 7a837a2 into react-component:master Sep 25, 2016
@benjycui
Copy link
Member

还没发布?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants