Skip to content

fix: onHeaderCell missing title #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix: onHeaderCell missing title #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
041bcba
test: test driven
zombieJ Jan 4, 2023
c65aef2
fix: title missing
zombieJ Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/Cell/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,13 @@ function Cell<RecordType>(props: CellProps<RecordType>) {
}

// >>>>> Title
const title = getTitleFromCellRenderChildren({
rowType,
ellipsis,
children: childNode,
});
const title =
additionalProps.title ??
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个换行看着有点难受

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是 prettier 的风格，无须关心。

getTitleFromCellRenderChildren({
rowType,
ellipsis,
children: childNode,
});

// >>>>> ClassName
const mergedClassName = classNames(
Expand Down
21 changes: 21 additions & 0 deletions tests/Cell.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,25 @@ describe('Table.Cell', () => {
wrapper.find('button').simulate('click');
expect(wrapper.find('.rc-table-tbody .rc-table-cell').text()).toEqual('2');
});

it('onHeaderCell', () => {
const wrapper = mount(
<Table
columns={[
{
title: (
<div>
<p>NotYet</p>
</div>
),
onHeaderCell: () => ({
title: 'Bamboo',
}),
},
]}
/>,
);

expect(wrapper.find('thead th').prop('title')).toEqual('Bamboo');
});
});