Skip to content

Conversation

vaakian
Copy link
Contributor

@vaakian vaakian commented Mar 31, 2023

did two things:

  • improve auto completion, by using the same technique that ant-design is using: LiteralUnion
  • remove redundant type annotation: the union type React.ReactNode already has string

image

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
table ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 4:05PM (UTC)

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #977 (922f4d9) into master (a9490ca) will not change coverage.
The diff coverage is n/a.

❗ Current head 922f4d9 differs from pull request most recent head 3e84114. Consider uploading reports for the commit 3e84114 to get more accurate results

@@           Coverage Diff           @@
##           master     #977   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          36       36           
  Lines         989      989           
  Branches      305      320   +15     
=======================================
  Hits          984      984           
  Misses          5        5           
Impacted Files Coverage Δ
src/Table.tsx 99.06% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afc163 afc163 merged commit d207818 into react-component:master Apr 18, 2023
@vaakian vaakian deleted the feat/type branch April 18, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants